[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#26489] [PATCH] substitute: Ignore bad responses.
From: |
zimoun |
Subject: |
[bug#26489] [PATCH] substitute: Ignore bad responses. |
Date: |
Fri, 18 Dec 2020 21:19:16 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi Tobias,
Your patch #26489 sent a couple of years ago since lost in the vacuum of
the crazy Debbugs. Patch is here:
<http://issues.guix.gnu.org/issue/26489>
On Mon, 01 May 2017 at 15:14, ludo@gnu.org (Ludovic Courtès) wrote:
>> I think throwing an unhandled exception is definitely the wrong thing to
>> do here — this kills even ‘guix --keep-going --fallback’. I'm less sure
>> about the right place to do it
>
> Oh right, if that kills --fallback, that’s a problem.
>
> Back to your initial patch, what about moving ‘bad-response’ handling to
> the call site of ‘http-multiple-get’ instead of having it in
> ‘http-multiple-get’? (That way, ‘http-multiple-get’ would behave like
> ‘http-get’ in this respect.)
>
> Upon a ‘bad-response’, ‘fetch-narinfos’ would return #f or the empty
> list or the partial narinfo list it has built so far.
>
> WDYT?
>
> I’d be happy with a patch along these lines!
Tobias, do you plan to rework/rebase it?
All the best,
simon
- [bug#26489] [PATCH] substitute: Ignore bad responses.,
zimoun <=