[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#45105] [PATCH] gnu: Add mbpfan service
From: |
Mathieu Othacehe |
Subject: |
[bug#45105] [PATCH] gnu: Add mbpfan service |
Date: |
Wed, 06 Jan 2021 11:11:08 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hello Niklas,
> * gnu/services/mbpfan.scm (mbpfan service): New variable.
Thanks for your contribution and sorry for the late review.
> + #$@(if verbose?
> + '("-v") ; verbose logging
> + '()))
> + #:log-file #$log-file))
The indentation is off here.
> + (list (service-extension shepherd-root-service-type
> mbpfan-shepherd-service)))
You should wrap this line to stay under the 78 cols limit.
You also need to add this file to 'gnu/local.mk'. It would also be nice
to write some documentation, probably under "Power management services".
Could you please send an updated patch?
Thanks,
Mathieu
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#45105] [PATCH] gnu: Add mbpfan service,
Mathieu Othacehe <=