[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#45893] [PATCH 0/2] DRAFT: Hint for options.
From: |
Ludovic Courtès |
Subject: |
[bug#45893] [PATCH 0/2] DRAFT: Hint for options. |
Date: |
Tue, 19 Jan 2021 18:38:01 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
zimoun <zimon.toutoune@gmail.com> skribis:
> * guix/ui.scm (run-guix-command): Add command hint.
[...]
> + (fold (lambda (name res)
> + (if (string-null? res)
> + (string-append "@code{" name "}")
> + (string-append "@code{" name "}, " res)))
> + ""
> + (string-closest (symbol->string guess) command-names)))
Hmm I thought ‘string-closest’ would return a single string, but
actually it returns a list of strings?
You cannot append strings together like this as this can break i18n.
The proper way would be to write:
"Do you mean one of these: ~a?"
but then, thinking about it, wouldn’t it be more natural to suggest a
single command rather than several?
Also, it seems to me that there’s always at least one hit, is that
correct? We should make sure that strings above a certain distance are
ignored, in which case there’s no hint to display.
Thanks!
Next up is package names, right? :-)
Ludo’.
- [bug#45893] [PATCH 0/2] DRAFT: Hint for options., zimoun, 2021/01/15
- [bug#45893] [PATCH 1/2] scripts: search, show: Replace 'args-fold*' by 'parse-command-line'., zimoun, 2021/01/15
- [bug#45893] [PATCH v2 0/3] DRAFT: Hint command line typo, zimoun, 2021/01/15
- [bug#45893] Hint for package name: too slow!, zimoun, 2021/01/19
- [bug#45893] Hint for package name: full matrix iteration, zimoun, 2021/01/20
- [bug#45893] [PATCH 0/2] DRAFT: Hint for options., Ludovic Courtès, 2021/01/26
- [bug#45893] [PATCH 0/2] DRAFT: Hint for options., zimoun, 2021/01/26
- [bug#45893] [PATCH 0/2] DRAFT: Hint for options., Ludovic Courtès, 2021/01/27
- [bug#45893] [PATCH v2 2/3] guix: scripts: Add hint for option typo., zimoun, 2021/01/15
- [bug#45893] [PATCH 0/2] DRAFT: Hint for options., Ludovic Courtès, 2021/01/19