[bug#46018] [PATCH] Add dwl.

[Nicolas Goaziou]

Hello,

Z572 <873216071@qq.com> writes:

> Subject: [PATCH] gnu: Add dwl.

Thank you! Some comments follow.

> +(define-public dwl
> +  (package
> +    (name "dwl")
> +    (version "0.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/djpohly/dwl";)
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "18g2sx8cv54zl5iw5m9lzngrp6ra2pyp7c68qps2ava3brw9m0j2"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f                      ; no tests
> +       #:make-flags
> +       (list
> +        "CC=gcc"

Instead of "CC=gcc", you should use

                 (string-append "CC=" ,(cc-for-target))

for cross-compilation.

> +        (string-append "PREFIX=" %output))

Here, I think it is preferable to use

          (string-append "PREFIX=" (assoc-ref %outputs "out"))

> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)            ; no configure
> +         (replace 'install              ; no install targer

Typo: ";no install target"

> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (bin (string-append out "/bin")))
> +               (install-file "dwl" bin)))))))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("wlroots" ,wlroots)))
> +    (home-page "https://github.com/djpohly/dwl";)
> +    (synopsis "Dwm for Wayland")

It would be nice to expound Dwm, e.g.,

  "Dynamic window manager for Wayland"

> +    (description
> +     "A compact, hackable compositor for Wayland based on wlroots.  It is

This should be a complete sentence, e.g.,

  Dwl is a compact, hackable...
   
> +intended to fill the same space in the Wayland world that dwm does in X11,
> +primarily in terms of philosophy, and secondarily in terms of functionality.
> +Like dwm, dwl is:
> +@itemize
> +@item Easy to understand, hack on, and extend with patches
> +@item One C source file (or a very small number) configurable via config.h
> +@item Limited to 2000 SLOC to promote hackability
> +@item Tied to as few external dependencies as possible

I suggest rewrite so it doesn't include a list. For example:

  Like dwm, dwl is easy to understand and hack on, due to a limited
  size and a few external dependencies.  It is configurable via @file{config.h}.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou