[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#45889] Nextcloud Client (v16)
From: |
Leo Prikler |
Subject: |
[bug#45889] Nextcloud Client (v16) |
Date: |
Tue, 09 Mar 2021 12:39:01 +0100 |
User-agent: |
Evolution 3.34.2 |
Hi Raghav,
Mostly LGTM.
Am Dienstag, den 09.03.2021, 05:50 -0500 schrieb Raghav Gururajan:
> > Definitely deserves a comment and perhaps a less broad match?
>
> Done the comment.
>
> I think this is perfect match. The mentioned libraries will get
> linked
> wherever synclib gets linked. Also, this patch is compatible with
> current master, which is different from this version.
Perhaps the comment should reflect that a little better. You might
also want to expand that during the unvendoring in the snippet, so that
it's less confusing.
> + `(("src" ,(string-append
> "include/" solution)
> + #:include-regexp ("\\.h$"))
I think you should unvendor dependencies between the solutions, so that
you can put them in "include/" directly (like putting the solutions in
"/lib").
Regards,
Leo
- [bug#45889] Nextcloud Client (v15), Raghav Gururajan, 2021/03/09
- [bug#45889] Nextcloud Client (v15), Leo Prikler, 2021/03/09
- [bug#45889] Nextcloud Client (v16), Raghav Gururajan, 2021/03/09
- [bug#45889] Nextcloud Client (v16),
Leo Prikler <=
- [bug#45889] Nextcloud Client (v16), Raghav Gururajan, 2021/03/09
- [bug#45889] Nextcloud Client (v17), Leo Prikler, 2021/03/09
- [bug#45889] Nextcloud Client (v18), Raghav Gururajan, 2021/03/09
- bug#45889: Nextcloud Client (v18), Leo Prikler, 2021/03/09
- [bug#45889] Nextcloud Client (v18), Raghav Gururajan, 2021/03/09
- [bug#45889] Nextcloud Client (v18), Raghav Gururajan, 2021/03/11
- [bug#45889] Nextcloud Client (v18), Leo Prikler, 2021/03/11
- [bug#45889] Nextcloud Client (v18), Raghav Gururajan, 2021/03/11
- [bug#45889] Nextcloud Client (v18), david larsson, 2021/03/12
- [bug#45889] Nextcloud Client (v18), Raghav Gururajan, 2021/03/12