guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#47042] gnu: qtsolutions: Enable examples.


From: Leo Prikler
Subject: [bug#47042] gnu: qtsolutions: Enable examples.
Date: Wed, 10 Mar 2021 13:58:35 +0100
User-agent: Evolution 3.34.2

Am Mittwoch, den 10.03.2021, 06:09 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> Currently with this patch, we have following issues:
> 
> [1] When examples are enabled for QtSingleApplication, it doesn't
> get 
> linked to QtLockFile. (Try building without `;; Disable building of 
> examples for QtSingleApplication.` block)
Then I guess we have to rewrite that Makefile (or pseudo-Makefile) in
the snippet as well? 

> [2] For installation of examples, the binaries get installed in sub-
> dirs 
> as `/bin/foo` instead of `/bin`.
I don't think the compiled examples need to be installed at all –
rather their source code etc. should be installed to share/doc (in a
qtsolutions subfolder of course).  The act of compiling them is merely
a check, that they (plus the code they are an example of) "work as
intended" or at least compile as intended.

If I read your patch correctly, I made an indentation mistake during
the review process, is that correct?

Regards,
Leo






reply via email to

[Prev in Thread] Current Thread [Next in Thread]