[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#46182] [PATCH] lint: Add 'check-git-protocol' checker.
|
From: |
Ludovic Courtès |
|
Subject: |
[bug#46182] [PATCH] lint: Add 'check-git-protocol' checker. |
|
Date: |
Thu, 11 Mar 2021 23:29:37 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi!
Leo Famulari <leo@famulari.name> skribis:
> We could also make it warn about use of the HTTP protocol (as opposed to
> HTTPS). Your thoughts?
>
> * guix/lint.scm (check-git-protocol): New procedure.
> (%local-checkers): Add 'git-protocol' checker.
> * doc/guix.texi (Invoking guix lint): Document it.
Nice! I think it’s OK to use ‘eqv?’ here (‘eq?’, even).
One nit: it would be nice to add a positive and a negative test in
tests/lint.scm. You can run “make check TESTS=tests/lint.scm” then.
Otherwise LGTM!
Thanks,
Ludo’.