[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#47013] [PATCH] gnu: Harden filesystem links.
From: |
Ludovic Courtès |
Subject: |
[bug#47013] [PATCH] gnu: Harden filesystem links. |
Date: |
Tue, 16 Mar 2021 23:18:18 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi!
Leo Famulari <leo@famulari.name> skribis:
> On Fri, Mar 12, 2021 at 05:05:51PM -0500, Leo Famulari wrote:
>> Here is an updated patch that can be composed with other
>> sysctl-service-types that the user may have added to config.scm.
>
> The only issue that I see with this revised patch is that it's not clear
> how users could disable these default settings if they wanted to.
With your first patch, to change the default settings, one has to write:
(modify-services %base-services
(sysctl-service-type config => …))
With your first patch, someone who already had a ‘sysctl-service-type’
instance as part of their services would now get an error at reconfigure
time.
Your second patch nicely addresses that; the downside is that it
actually makes it slightly harder to change the defaults because you
wouldn’t know what to pass in your ‘modify-services’ form.
All in all, I have a slight preference for the first patch. It could be
accompanied with a news.scm entry to explain the incompatible change,
maybe.
Thoughts?
Thanks,
Ludo’.
- [bug#47013] [PATCH] gnu: Harden filesystem links., Leo Famulari, 2021/03/08
- [bug#47013] [PATCH] gnu: Harden filesystem links., Leo Famulari, 2021/03/12
- [bug#47013] [PATCH] gnu: Harden filesystem links., Leo Famulari, 2021/03/12
- [bug#47013] [PATCH] gnu: Harden filesystem links., Leo Famulari, 2021/03/15
- [bug#47013] [PATCH] gnu: Harden filesystem links., Ludovic Courtès, 2021/03/16
- [bug#47013] [PATCH] gnu: Harden filesystem links., Julien Lepiller, 2021/03/18
- [bug#47013] [PATCH] gnu: Harden filesystem links., Leo Famulari, 2021/03/18
- [bug#47013] [PATCH] gnu: Harden filesystem links., Julien Lepiller, 2021/03/18
- [bug#47013] [PATCH] gnu: Harden filesystem links.,
Ludovic Courtès <=
- [bug#47013] [PATCH] gnu: Harden filesystem links., Leo Famulari, 2021/03/16
- [bug#47013] [PATCH v4] gnu: Harden filesystem links., Leo Famulari, 2021/03/16
- [bug#47013] [PATCH] gnu: Harden filesystem links., Ludovic Courtès, 2021/03/17
- [bug#47013] [PATCH] gnu: Harden filesystem links., Leo Famulari, 2021/03/17
- [bug#47013] [PATCH] gnu: Harden filesystem links., Leo Famulari, 2021/03/18
- [bug#47013] [PATCH] gnu: Harden filesystem links., Ludovic Courtès, 2021/03/18
- [bug#47013] [PATCH] gnu: Harden filesystem links., Leo Famulari, 2021/03/18
[bug#47013] (no subject), muradm, 2021/03/24
[bug#47013] services: export sysctl-configuration record field accessors, muradm, 2021/03/24