guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#45905] [PATCH v3] IPFS service definition


From: Maxime Devos
Subject: [bug#45905] [PATCH v3] IPFS service definition
Date: Tue, 30 Mar 2021 15:37:46 +0200
User-agent: Evolution 3.34.2

Hi Guix,

Revised patch series is attached.

Changes in v2:

* let the shepherd service depend on (loopback) instead of
  (networking)
* added a (broken) system test for the IPFS service

Changes in v3:

* added 'extensions' argument to 'marionette-operating-system'. 
* fixed the system test
* tweaked the documentation formatting and removed a misleading comment
  on forwarding (port forwarding would be fine here, as the test is run
  in a container so there is no risk of port conflicts IIUC)

Ludovic Courtès wrote:
> Nitpick: please avoid ‘@’.  Instead, explicitly do:
> [...]

I actually prefer '(@ (...) ...)' here, but whatever.  It's changed
in v3.

> As it stands, the test fails because you need to:
>  (define test
>    (with-extensions (list guile-json)
>      …))

As the uploading and downloading is done in the guest, not the host,
this needs to be done somewhat differently.  That's what the patch
‘tests: Support package extensions in the backdoor REPL’ is for.

Greetings,
Maxime

Attachment: 0001-services-Add-ipfs-service-type.patch
Description: Text Data

Attachment: 0002-Add-guix-ipfs.patch
Description: Text Data

Attachment: 0003-tests-Support-package-extensions-in-the-backdoor-REP.patch
Description: Text Data

Attachment: 0004-gnu-tests-Test-basic-funtionality-of-the-IPFS-servic.patch
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]