[bug#47923] gnu: Add daemonize.

[Leo Famulari]

On Wed, Apr 21, 2021 at 02:37:02AM +0530, Winter Hound wrote:
> From f9e100cf01ea72544996b54b78a08502ca33a413 Mon Sep 17 00:00:00 2001
> From: WinterHound <winterhound@yandex.com>
> Date: Wed, 21 Apr 2021 02:17:13 +0530
> Subject: [PATCH] gnu: Add daemonize.

Thanks for the patch!

Don't forget to add yourself to the list of authors of
gnu/packages/admin.scm. There's an example in commit
3ddece896fddc38a29ab7e69f7c74f35e5a381fb, which was your patch adding
kirc:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3ddece896fddc38a29ab7e69f7c74f35e5a381fb

> +    (arguments
> +     `(#:tests? #f

I'm guessing this program doesn't have a test suite?

We prefer to document why #:tests? are #f. A code comment like "No test
suite" is sufficient.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-makefile
> +           (lambda _
> +             (substitute* "Makefile.in"
> +               (("/sbin") "/bin")) #t)))))

Why change this output directory? We usually respect the upstream
decision about whether executable binaries go in 'sbin' or 'bin'. Guix
will add both directories to $PATH, so it will work either way.

Otherwise, looks good! Can you send a revised patch or answer those
questions?