[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#47921] [PATCH] build: Fix elf-dynamic-info-soname.
From: |
Maxime Devos |
Subject: |
[bug#47921] [PATCH] build: Fix elf-dynamic-info-soname. |
Date: |
Wed, 21 Apr 2021 13:49:33 +0200 |
User-agent: |
Evolution 3.34.2 |
Dion Mendel schreef op wo 21-04-2021 om 03:44 [+0800]:
> * guix/build/gremlin.scm (elf-dynamic-info-soname): Return the value of
> the dynamic-entry instead of the dynamic-entry record itself.
1. IIUC, this change would cause a world-rebuild, so this patch would have
to applied on core-updates. The subject line should have been
[PATCH core-updates]: etcetera.
2. How did you test this patch?
3. What does this patch fix?
4. elf-dynamic-info-soname is a record accessor. Did you mean elf-dynamic-info?
5. According to the docstring (core-updates,
c9a61dff8242612ae8275829a5ee31ff45ff08b1):
"Return dynamic-link information for ELF as an <elf-dynamic-info> object, or
#f if ELF lacks dynamic-link information."
So this patch actually _introduces_ a bug. Or you need to modify the
docstring
as well.
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part
[bug#47921] [PATCH] build: Fix elf-dynamic-info-soname., Dion Mendel, 2021/04/21
[bug#47921] retitle, Dion Mendel, 2021/04/21
[bug#47921] Include correct commit message, Dion Mendel, 2021/04/21