[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#47336: Disarchive as a fallback for downloads
From: |
Timothy Sample |
Subject: |
bug#47336: Disarchive as a fallback for downloads |
Date: |
Thu, 29 Apr 2021 13:24:09 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello,
Ludovic Courtès <ludo@gnu.org> writes:
> Timothy Sample <samplet@ngyro.com> skribis:
>
>> And broke “guix pull”!! (I somehow fooled myself into thinking that I
>> had already tested with “guix pull --url=...” locally.) I reverted the
>> offending commit.
>
> You can test with ‘guix pull’ (you need to make sure to specify the
> right file:// URL *and* branch), or you can run “make as-derivation”.
I will definitely be more careful with this in the future.
>> [...] Does this approach look okay?
>
> That’s one possibility.
>
> The patch below takes another approach. I think it aesthetically
> slightly more pleasant because we don’t have to play ‘resolve-module’
> tricks for obscure reasons. WDYT?
This is exactly what I was hoping for, but I couldn’t quite connect all
the dots in “build-self.scm”. Thanks!
> (It also fixes a format string argument mismatch.)
Good catch!
I’ve pushed the updated patch and am closing the issue. :)
-- Tim