[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48027] [PATCH] gnu: Add volctl.
From: |
Ludovic Courtès |
Subject: |
[bug#48027] [PATCH] gnu: Add volctl. |
Date: |
Mon, 03 May 2021 23:09:22 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi Simon,
Simon Streit <simon@netpanic.org> skribis:
> * gnu/packages/gtk.scm: New Variable.
[...]
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/buzz/" name
> + "/archive/v" version ".tar.gz"))
> + (sha256
> + (base32
> + "1xanqn6s2i6s2n6wysvgz6l58lsdkl3zmzz4hccla01gx7h4yx4f"))))
To placate ‘guix lint’, could you (1) use ‘git-fetch’ instead of
referring to an autogenerated tarball, and (2) add a ‘file-name’ field
as done elsewhere?
> + (arguments
> + `(#:tests? #t
You can remove this line, it’s the default.
> + (synopsis "Per-application volume control and OSD for Linux desktops")
> + (description "Volctl is a PulseAudio-enabled tray icon volume control and
> +OSD applet for Linux desktops. It's not meant to be an replacement for a
I’d suggest:
s/OSD/on-screen display (OSD)/
s/Linux desktops/graphical desktops/
Could you send an updated patch?
Thank you,
Ludo’.
- [bug#48027] [PATCH] gnu: Add volctl.,
Ludovic Courtès <=