[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48726] [PATCH] gnu: nsis: Respect SOURCE-DATE-EPOCH for reproducibi
From: |
Ludovic Courtès |
Subject: |
[bug#48726] [PATCH] gnu: nsis: Respect SOURCE-DATE-EPOCH for reproducibility |
Date: |
Tue, 01 Jun 2021 23:19:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi,
Carl Dong <contact@carldong.me> skribis:
> * gnu/packages/patches/nsis-SConstruct-sde-support.patch: New patch.
> * gnu/packages/installers.scm (make-nsis)[source]: Apply it.
Nice! Minor issues:
> gnu/packages/installers.scm | 3 ++-
> .../patches/nsis-SConstruct-sde-support.patch | 15 +++++++++++++++
How about ‘nsis-source-date-epoch.patch’? It might be slightly clearer
in my view.
Please make sure to add it to ‘gnu/local.mk’.
> diff --git a/gnu/packages/patches/nsis-SConstruct-sde-support.patch
> b/gnu/packages/patches/nsis-SConstruct-sde-support.patch
> new file mode 100644
> index 0000000000..5edf1b7c8e
> --- /dev/null
> +++ b/gnu/packages/patches/nsis-SConstruct-sde-support.patch
Please add a line at the top saying what it does and linking to the
upstream issue (or ‘guix lint’ will complain, which would be so bad :-)).
OK to push with these changes, thank you!
Ludo’.
- [bug#48726] [PATCH] gnu: nsis: Respect SOURCE-DATE-EPOCH for reproducibility,
Ludovic Courtès <=