[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48729] [PATCH v2 47/47] gnu: Add bitmask-vpn.
From: |
Maxime Devos |
Subject: |
[bug#48729] [PATCH v2 47/47] gnu: Add bitmask-vpn. |
Date: |
Thu, 03 Jun 2021 23:47:35 +0200 |
User-agent: |
Evolution 3.34.2 |
One comment about this patch.
Raghav Gururajan via Guix-patches via schreef op do 03-06-2021 om 16:51 [-0400]:
>
> + (replace 'build
> + (lambda* (#:key source system outputs search-paths build-flags
> unpack-path inputs #:allow-other-keys)
> + (for-each
> + (lambda (directory)
> + ((assoc-ref %standard-phases 'build)
> + #:source source
> + #:system system
> + #:outputs outputs
> + #:search-paths search-paths
> + #:build-flags build-flags
> + #:unpack-path unpack-path
> + #:inputs inputs
> + #:import-path directory))
> + (list [...]
This can be done a bit simpler, and less prone to breakage
if/when a new keyword argument is introduced at some poit
in the future (untested):
(replace 'build
(lambda arguments
(lambda (directory)
(apply (assoc-ref %standard-phases 'build)
`(,@arguments #:directory ,directory)))))
WDYT? Likewise in other places.
Also, trailing #t in phases aren't required anymore
(but harmless), though you probably know that already.
(The warning should disappear when core-updates is merged.)
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part
- [bug#48729] [PATCH v2 40/47] gnu: Add go-github-com-grd-glfw3., Raghav Gururajan, 2021/06/03
- [bug#48729] [PATCH v2 41/47] gnu: Add go-github-com-go-gl-glow., Raghav Gururajan, 2021/06/03
- [bug#48729] [PATCH v2 42/47] gnu: Add go-github-com-go-gl-gl., Raghav Gururajan, 2021/06/03
- [bug#48729] [PATCH v2 43/47] gnu: Add go-github-com-skelterjohn-go-wde., Raghav Gururajan, 2021/06/03
- [bug#48729] [PATCH v2 45/47] gnu: Add go-github-com-sqweek-dialog., Raghav Gururajan, 2021/06/03
- [bug#48729] [PATCH v2 46/47] gnu: Add go-0xacab-org-leap-go-dialog., Raghav Gururajan, 2021/06/03
- [bug#48729] [PATCH v2 44/47] gnu: Add go-github-com-skratchdot-open-golang., Raghav Gururajan, 2021/06/03
- [bug#48729] [PATCH v2 47/47] gnu: Add bitmask-vpn., Raghav Gururajan, 2021/06/03
- [bug#48729] [PATCH v2 47/47] gnu: Add bitmask-vpn.,
Maxime Devos <=