[bug#48729] [PATCH v2 05/47] gnu: Add go-github-com-keybase-go-ps.

[Maxime Devos]

Raghav Gururajan via Guix-patches via schreef op do 03-06-2021 om 05:57 [-0400]:
> +         (modify-phases %standard-phases
> +           (add-after 'unpack 'fix-tests
> +             (lambda* (#:key inputs #:allow-other-keys)
> +               (substitute* (find-files "." ".*test\\.go")
> +                 (("/bin/sleep")
> +                  (string-append (assoc-ref inputs "coreutils")
> +                                 "/bin/sleep")))

When cross-compiling, coreutils is not in 'inputs', but in 'native-inputs', 
right?
So this would lead to a build error when cross-compiling.
(assoc-ref inputs "coreutils") would return #f, thus you'd get an exception

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure string-append: Wrong type (expecting string): #f

I would make this (untested):

  (sring-append (assoc-ref (or native-inputs inputs) "coreutils") "/bin/sleep")

Greetings,
Maxime.

signature.asc
Description: This is a digitally signed message part