[bug#48696] [PATCH v2 1/4] doc: Structure the "Commit Access" section.

[Xinglu Chen]

On Sun, Jun 13 2021, Ludovic Courtès wrote:

> * doc/contributing.texi (Commit Access): Add introduction and section
> heading.  Separate OpenPGP setup from commit policy.
> ---
>  doc/contributing.texi | 59 ++++++++++++++++++++++++++++---------------
>  1 file changed, 38 insertions(+), 21 deletions(-)
>
> diff --git a/doc/contributing.texi b/doc/contributing.texi
> index d67e632520..4ab489173b 100644
> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -1275,8 +1275,19 @@ this nifty tool!
>  @section Commit Access
>  
>  @cindex commit access, for developers
> -For frequent contributors, having write access to the repository is
> -convenient.  When you deem it necessary, consider applying for commit
> +Everyone can contribute to Guix without having commit access
> +(@pxref{Submitting Patches}).  However, for frequent contributors,
> +having write access to the repository can be convenient.  Commit access
> +should not be thought of as a ``badge of honor'' but rather as a
> +responsibility a contributor is willing to take to help the project.
> +
> +The following sections explain how to get commit access, how to be ready
> +to push commits, and the policies and community expectations for commits
> +pushed upstream.
> +
> +@subsection Applying for Commit Access
> +
> +When you deem it necessary, consider applying for commit
>  access by following these steps:
>  
>  @enumerate
> @@ -1348,6 +1359,27 @@ review and merging system, which, as a consequence, 
> may lead us to have
>  fewer people with commit access to the main repository.  Stay tuned!
>  @end quotation
>  
> +All commits that are pushed to the central repository on Savannah must
> +be signed with an OpenPGP key, and the public key should be uploaded to
> +your user account on Savannah and to public key servers, such as
> +@code{keys.openpgp.org}.  To configure Git to automatically sign
> +commits, run:
> +
> +@example
> +git config commit.gpgsign true
> +git config user.signingkey CABBA6EA1DC0FF33
> +@end example
> +
> +You can prevent yourself from accidentally pushing unsigned commits to
> +Savannah by using the pre-push Git hook called located at
> +@file{etc/git/pre-push}:

I think you forgot to remove “called” :)

signature.asc
Description: PGP signature