[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#48977: [PATCH 4/4] gnu: Add openjdk16.
From: |
Pierre Langlois |
Subject: |
bug#48977: [PATCH 4/4] gnu: Add openjdk16. |
Date: |
Sun, 13 Jun 2021 18:03:39 +0100 |
User-agent: |
mu4e 1.4.15; emacs 27.2 |
Hi Julien,
Julien Lepiller writes:
> Le Sat, 12 Jun 2021 20:54:49 +0100,
> Pierre Langlois <pierre.langlois@gmx.com> a écrit :
>
>> + (arguments
>> + (substitute-keyword-arguments (package-arguments openjdk15)
>> + ((#:phases phases)
>> + `(modify-phases ,phases
>> + (add-after 'unpack 'make-templates-writable
>> + (lambda _
>> + ;; The build system copies a few .template files from
>> the
>> + ;; source directory into the build directory and then
>> modifies
>> + ;; them in-place. So these files have to be writable.
>> + (for-each
>> + (lambda (file)
>> + (invoke "chmod" "u+w" file))
>> + (find-files
>> "src/java.base/share/classes/jdk/internal/misc/"
>> + "\\.template"))
>
> Should be "\\.template$", otherwise the whole series LGTM!
Thanks for the review! Fixed and pushed with
afd4924d6a64c01a1d5138954b9f22c9bd4f4690.
Pierre
signature.asc
Description: PGP signature