[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48320] [PATCH] lint: Verify if #:tests? is respected in the 'check'
From: |
Mathieu Othacehe |
Subject: |
[bug#48320] [PATCH] lint: Verify if #:tests? is respected in the 'check' phase. |
Date: |
Fri, 18 Jun 2021 14:15:50 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello Maxime,
> + (`(,(or 'lambda 'lambda*) ,_ (invoke . ,_) . ,_)
> + (list (make-warning package
> + ;; TRANSLATORS: check and #:tests? are a Scheme
> + ;; symbol and keyword respectively and should not
> + ;; be translated.
> + (G_ "the 'check' phase should respect #:tests?")
> + #:field 'arguments)))
I like the idea behind this patch. However I think the detection pattern
could be improved for instance, here are a few unreported packages:
- dejagnu
- python-dateutil
- eigen
Maybe we should check directly if the tests? variable is used within the
'check replace phase?
Thanks,
Mathieu
- [bug#48320] [PATCH] lint: Verify if #:tests? is respected in the 'check' phase.,
Mathieu Othacehe <=