[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#49054] Add borg-sans-mono Font
From: |
Charles |
Subject: |
[bug#49054] Add borg-sans-mono Font |
Date: |
Sat, 19 Jun 2021 16:33:06 +0000 |
Thank you so much for reviewing my patch, and helping me correct it. Attatched
is an fixed version.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, June 16th, 2021 at 1:33 AM, Leo Prikler
<leo.prikler@student.tugraz.at> wrote:
> Am Mittwoch, den 16.06.2021, 00:53 +0000 schrieb Charles:
>
> > This is my first contribution, so let me know if I did something
> >
> > wrong. The patch is attatched.
>
> > > Subject: [PATCH] gnu: Add font-borg-sans-mono
> > >
> > > - gnu/packages/fonts.scm (font-borg-sans-mono): Add font
>
> Nitpicky, but the dot in the headerline is missing and we usually
>
> denote new packages by "new variable" since that's what they are on
>
> Scheme level.
>
> > - (name "font-borg-sans-mono")
> > - (version "0.3.0")
> > - (home-page "https://github.com/charje/borg-sans-mono")
>
> home-page usually comes after build-system+arguments.
>
> > - (uri (string-append
> >
> >
> > - home-page
> >
> >
> > - "/releases/download/v"
> >
> >
> > - version
> >
> >
> > - "/borg-sans-mono.zip"))
> >
> >
>
> Please type out home-page. It could very well be, that the devs start
>
> some fancy Github Pages website, which would break this code.
>
> > - (description "Droid Sans Mono Slashed + Hasklig-style
> >
> > ligatures!")
>
> This is not very descriptive at all, I'm afraid. If Hasklig or Monoid
>
> are a reasonable alternative to this font, it's probably easier to find
>
> a description for them.
>
> Regards,
>
> Leo
0001-gnu-Add-new-variable-font-borg-sans-mono.patch
Description: Text Data