|
From: | Adu O'Hara |
Subject: | [bug#49203] [PATCH 1/2] gnu: Add ocaml-uri-sexp. |
Date: | Thu, 24 Jun 2021 19:32:30 +0000 |
Xinglu Chen <public@yoctocell.xyz> writes:
On Thu, Jun 24 2021, Adu O'Hara wrote:Thanks for the patches!There is already an `ocaml-uri`. How about updating that to 4.2.0 (currently at 4.1.0) and let `ocaml-uri-sexp` inherit from ocaml-uri with #:package set to "uri-sexp"?That could probably be done in a separate patch series; this series isabout adding ‘ocaml-cohttp’.
True, what I was suggesting would add another patch to the series and mix up intentions of the series. Still, I'd suggest for ocaml-uri-sexp to inherit from ocaml-uri. Otherwise we have them at two different versions.
wdyt?
Another alternatively: remove the #:package argument from `ocaml-uri` so that all packages are built (`uri`, `uri-sexp` and `uri-re`).Those are three separate packages on Opam, so I don’t think it makessense for us to merge them into one. Not everyone who installs‘ocaml-uri’ is going to want ‘ocaml-uri-sexp’ and ‘ocaml-uri-re’.WDYT?
Yeah, that make sense. Keeping them separate sounds good.
[Prev in Thread] | Current Thread | [Next in Thread] |