[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#49425] [PATCH] guix-install.sh: Prompt for configuring substitutes
From: |
Ludovic Courtès |
Subject: |
[bug#49425] [PATCH] guix-install.sh: Prompt for configuring substitutes discovery. |
Date: |
Tue, 06 Jul 2021 16:44:48 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> +# Configure substitute discovery according to user's preferences.
> +# $1 is the installed service file to edit.
> +configure_substitute_discovery() {
> +if grep -q -- '--discover=no' "$1" && \
> + prompt_yes_no "Would you like to enable automatic substitute \
> +discovery? (yes/no)"; then
> + sed -i 's/--discover=no/--discover=yes/' "$1"
> +fi
> +}
Indentation is off, compared to the other functions.
Should the message say a bit more, similar to that in (gnu installer
newt substitutes)?
Otherwise LGTM!
Note that someone running “yes | ./guix-install.sh” will now have
substitutes enabled (whereas it’s off by default in
<guix-configuration>). I suppose that’s fine though.
Thanks,
Ludo’.