[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#50261] [PATCH] gnu: node: Enable cross-compilation.
From: |
Mathieu Othacehe |
Subject: |
[bug#50261] [PATCH] gnu: node: Enable cross-compilation. |
Date: |
Tue, 31 Aug 2021 15:41:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello Pierre,
> While working on tree-sitter I realized our node packages didn't
> cross-compile [0] so I thought I'd give it a go, here's a patch!
Nice!
> I'm not sure there's any way to express this restriction in the package
> definition, it would be good to fail in a useful way, any thoughts? I
> suspect a mechanism for this isn't really worth the effort, I don't know
> of any other packages like this.
Yeah that's a strange limitation, I don't think we have something
similar elsewhere. A restriction that compares the host and target
bitness is maybe not worth it.
> - (string-append (assoc-ref inputs "python")
> + (string-append (assoc-ref (or native-inputs inputs)
> "python")
You have several lines such as this one that are longer than the 78
columns limit.
Other than that, it looks cool, and you can go ahead.
Thanks,
Mathieu