|
From: | Vivien Kraus |
Subject: | [bug#50425] [PATCH] gnu: Add minetest-advtrains. |
Date: | Fri, 10 Sep 2021 14:46:39 +0200 |
User-agent: | Evolution 3.34.2 |
Hello Maxime, Le vendredi 10 septembre 2021 à 12:25 +0200, Maxime Devos a écrit : > minetest-advtrains and minetest-basic-trains are separate packages > that > can be added separately, so theoretically, they should be added in > separate > patches: It seems like the least surprising thing to do, so let’s go with the split patch. > Maybe replace ‘realistic trains’ -> ‘realistic train system’, I’m not sure. Upstream really likes to use "train" as a general term, like in share/minetest/mods/advtrains/modpack.conf, the official description, the wiki, ... so I think it’s better to use that. > and note that minetest-basic-trains contains the actual train models. This sentence was missing, and I added it. > I think a linter will have something to say about long lines here > (try "./pre-inst-env guix lint minetest-advtrains minetest-basic- > trains"). You’re right, I fixed the long lines and other warnings. However, I don’t know how to fix "no updater for minetest-xxx" for both minetest- advtrains and minetest-basic-trains. I can’t see a meaningful difference between my packages and the others. Vivien
0004-gnu-add-minetest-basic-trains.patch
Description: Text Data
0003-gnu-add-minetest-advtrains.patch
Description: Text Data
0002-gnu-minetest-mesecons-Fix-indentation.patch
Description: Text Data
0001-gnu-minetest-data-Fix-indentation.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |