[bug#50428] [PATCH] gnu: Add cryfs

[Brendan Tildesley]

Update attached.

> On 09/14/2021 11:50 AM Ludovic Courtès <ludo@gnu.org> wrote:
> 
>  
> Hi,
> 
> Brendan Tildesley <mail@brendan.scot> skribis:
> 
> > * gnu/packages/crypto.scm (cryfs): New variable.
> 
> Overall LGTM modulo the minor issues below:
> 
> > +     '(#:configure-flags
> > +       `("-DCRYFS_UPDATE_CHECKS=OFF" ;; Note: This also disables checking 
> > for security issues.
> > +         "-DCMAKE_BUILD_TYPE=Release" ;; Build man pages.
> 
> Normally this is set by #:build-type.  It defaults to “RelWithDebInfo”,
> which is nice because then you get debugging symbols if you pass
> ‘--with-debug-info=cryfs’.  So I’d suggest removing this second flag.
> 

I found a way to build man pages without it.

> > +         (replace 'check
> > +           (lambda* (#:key tests? outputs #:allow-other-keys)
> > +             (use-modules (srfi srfi-1))
> 
> Please use #:modules ((srfi srfi-1) …) instead of this non-top-level
> ‘use-modules’ form.
> 

done.

> > +             (when tests?
> > +               (with-directory-excursion "/tmp/build/test"
> > +                 (let ((tests (find-files "." "-test$"))
> > +                       (tests-output (assoc-ref outputs "tests")))
> > +                   ;; Install tests to a separate output so users can run 
> > them.
> > +                   (copy-recursively "." tests-output)
> 
> Installing tests is unusual.  Do you really think it’s going to be
> useful?

Not sure. I felt since the cryfs is for encrypting peoples files, they may want 
to run the tests themselves
to see if there any nasty issues. Most of the tests fail due to FUSE not being 
available, which works outside
the chroot. Anyways I removed installing them.

0001-gnu-Add-cryfs.patch
Description: Text Data