[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#50814] [PATCH 4/5] guix: Prepare the UI for continuable &warning ex
From: |
Attila Lendvai |
Subject: |
[bug#50814] [PATCH 4/5] guix: Prepare the UI for continuable &warning exceptions. |
Date: |
Wed, 29 Sep 2021 21:22:33 +0000 |
> About 1): which 'wind part' of dynamic-wind are you referring to?
>
> The in-guard or the out-guard?
>
> If the out-guard is empty, then the reference to the old connection will
> be overwritten when the fiber is paused and resumed, so the old connection
> will eventually be GC'ed, thus the daemon forgets some GC roots, leading
> to a rare GC bug.
>
> If the in-guard is empty, then the after pausing the fiber and resuming it,
> the connection will be closed while the fiber might still need it.
ok, so this is a no-go. thanks for the clarification!
> Conventionally, to emit warnings, the procedure 'warning' from
> (guix diagnostics) is used. See e.g. (guix ci), (guix deprecation), (guix
> gexp),
> (guix import ...), various modules under (guix scripts ...), (guix upstream)
> ...
>
> Is there any reason not to use this pre-existing procedure?
in a more advanced UI it might be a different story, but in the
current setup the only reason is to be able to assert for the warning
in the tests.
is that worth it? shall i just user WARNING and forget about the test?
- attila
PGP: 5D5F 45C7 DFCD 0A39
- [bug#50814] [PATCH 3/4] tests: Add failing test for .guix-authorizations and channel intro., (continued)
[bug#50814] [PATCH 3/5] tests: Add failing test for .guix-authorizations and channel intro., Attila Lendvai, 2021/09/28
[bug#50814] [PATCH 5/5] guix: git-authenticate: Fix authenticate-repository., Attila Lendvai, 2021/09/28