|
From: | Tom Fitzhenry |
Subject: | [bug#51548] [PATCH] services: Create /run and /var/run on activation. |
Date: | Thu, 4 Nov 2021 18:00:18 +1100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 |
Having thought about this patch some more, I think it can be better done. On 1/11/21 22:39, Tom Fitzhenry wrote:
;; thus there is no accounting at all. + (mkdir-p "/var/run")
This line will create /var/run if it doesn't exist during activation. This is safe, but there is already code that creates /var/run : https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/build/install.scm?id=63c356fe13f0c7cc560a1f9aeec4926422c22137#n120 . This runs on installation.
By adding this line, this responsibility is split across two parts of the code base: installation and activation. This could cause confusion.
If, as this patch intends, we want to be able to boot from just /boot, /gnu and /var/guix, perhaps we should move https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/build/install.scm?id=63c356fe13f0c7cc560a1f9aeec4926422c22137#n120 (and surrounding code) from running at install-time to running at activation-time.
[Prev in Thread] | Current Thread | [Next in Thread] |