guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#51587] [PATCH v2 0/3] gnu: Add rss2email.


From: Morgan . J . Smith
Subject: [bug#51587] [PATCH v2 0/3] gnu: Add rss2email.
Date: Thu, 11 Nov 2021 10:30:02 -0500

Thanks for the review!

I looked over both previously submitted sgmllib3k packages and I think my patch 
is the best as the description mentions SGML.

I fixed the sgmllib3k indentation issue and added a missing word to the 
description.

For the rss2email patch:
- I added my copyright to mail.scm
- I removed the inputs and outputs from the check phase
- Made the input not propagated. It is indeed a binary that seems to still work 
this way.
- Fixed that comment
- Slightly modified the description but I'm honestly not sure what the issue 
is. I'll admit I'm not very good at english so if you could just change it how 
you see fit that would make me happy


[PATCH v2 1/3] gnu: Add python-sgmllib3k.
[PATCH v2 2/3] gnu: python-feedparser: Add input
[PATCH v2 3/3] gnu: Add rss2email.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]