guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#52022] [PATCH] gnu: gst-plugins/selection: Fix behaviour when using


From: Liliana Marie Prikler
Subject: [bug#52022] [PATCH] gnu: gst-plugins/selection: Fix behaviour when using flags as-is.
Date: Sun, 21 Nov 2021 18:41:28 +0100

When using this gst-plugins/selection without setting configure-flags, the
existing flags are simply inherited.  This leads to an issue with
unquote-splicing when looking at quoted lists, e.g. as used by
gst-plugins-bad.

* gnu/packages/gstreamer.scm (gst-plugins-selection)[#:configure-flags]:
Only splice user-provided configure-flags, simply unquote those from existing
packages.

Reported-by: unmatched-paren, nckx (IRC)
---
 gnu/packages/gstreamer.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 2927055240..f7d0808b98 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -924,13 +924,15 @@ (define-public gst-plugins/selection
     (package/inherit pkg
       (arguments
        (substitute-keyword-arguments (package-arguments pkg)
-         ((#:configure-flags flags `(,@(or configure-flags '())))
+         ((#:configure-flags flags ''())
           `(append
             (list
              ,@(map (lambda (plugin)
                       (string-append "-D" plugin "=enabled"))
                     plugins))
-            (list ,@(or configure-flags flags))))
+            ,(if configure-flags
+                 `(list ,@configure-flags)
+                 flags)))
           ((#:phases phases)
            `(modify-phases ,phases
               (add-after 'unpack 'disable-auto-plugins
-- 
2.34.0







reply via email to

[Prev in Thread] Current Thread [Next in Thread]