[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#51990] [PATCH] gnu: Add emacs-bazel.
From: |
Nicolas Goaziou |
Subject: |
[bug#51990] [PATCH] gnu: Add emacs-bazel. |
Date: |
Sun, 21 Nov 2021 21:30:52 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello,
Brian Kubisiak <brian@kubisiak.com> writes:
> * gnu/packages/emacs-xyz (emacs-bazel): New variable.
Thank you. Some comments follow.
>
> Signed-off-by: Brian Kubisiak <brian@kubisiak.com>
We don't sign our own commits. So the line above is not necessary.
> +(define-public emacs-bazel
> + (package
> + (name "emacs-bazel")
> + (version "20211031.1941")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://melpa.org/packages/bazel-"
> + version ".el"))
We don't trust MELPA as a reliable source. Could you use git-fetch
instead, and get source files from upstream instead?
Also, the version is "O", according to "Version" keyword in "bazel.el"
file.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou