[bug#52275] [PATCH] gnu: syncthing: Update to 1.18.4.

[Leo Famulari]

On Sat, Dec 04, 2021 at 12:51:36PM +0100, simendsjo wrote:
> * gnu/packages/syncthing.scm (syncthing): Update to 1.18.4.
> +       ;; Running tests currently fails. Get the message
> +       ;; 
> vendor/github.com/lucas-clemente/quic-go/internal/qerr/error_codes.go:6:2: 
> build constraints exclude all Go files in 
> /tmp/guix-build-syncthing-1.18.4.drv-0/src/github.com/syncthing/syncthing/vendor/github.com/lucas-clemente/quic-go/internal/qtls
> +       ;; followed by two lines of `exit status 1`.
> +       ;; Running on a non-guix has the same problem as for guix, but the 
> tests runs.
> +       ;; We disable the tests for now
> +       #:tests? #f

Thanks for the patches!

Do you know what's wrong here? I think that we should at least
understand it before pushing an upgrade that doesn't pass its tests.

I tried building the entire 1.18 release series, and 1.18.0 does build
and pass its tests for me on x86_64. But I suppose there were good
reasons to make 4 minor releases since 1.18.0.