guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#52030] [PATCH] gnu: Add feather font


From: Jaft
Subject: [bug#52030] [PATCH] gnu: Add feather font
Date: Thu, 16 Dec 2021 21:24:33 +0000 (UTC)

> On Friday, December 10, 2021, 08:28:42 AM CST, Ludovic Courtès <ludo@gnu.org> 
> wrote: 
>
>
>
>
>
> Hi Jaft,
>
> > +    (name "font-atui-feather")
> > +    (version "0")
> > +    (source (origin
> > +              (method url-fetch/zipbomb)
> > +              (uri 
>"https://github.com/AT-UI/feather-font/archive/refs/heads/master.zip";)
> > +              (sha256 (base32 
>"0lp1m1a47s56rj0q6nj8j5snkbw8jq3q7zwdzf86sbbglq170inh"))))
>
> Note that ‘master.zip’ changes at each commit (and its content can also
> change even if the HEAD commit is unchanged because it’s a generated
> file.)
>
> Could you instead change it to refer to a non-generated zip file, or use
> ‘git-fetch’ to obtain a checkout?
>
> You may also need to adjust the version string.

Huh; sorry about that. I knew that and yet completely missed it, when writing 
this up. The repo. doesn't have any tags or releases (maybe that's what my 
brain was thinking when it originally used master) so I've just pointed it to 
the latest commit they'd made, in the revision.

> > +    (build-system font-build-system)
> > +    (home-page "https://at-ui.github.io/feather-font/";)
> > +    (synopsis "Iconfont version of Feather")
> +    (description "Feather is a collection of simply beautiful open source 
> icons.
>
> Everything is free software/data in Guix, so you can remove “open
> source”.  :-)

Haha; oh, right: fair point. Removed.

> Could you send an updated patch?  Preferably as a attachment to make
> sure it’s not mangled on its way.
>
> Thanks in advance!
>
> Ludo’.

For some reason, I only remembered the part of the documentation that says you 
can submit the patch in the body of the E-mail but, double-checking my memory, 
it definitely also lists being able to send the patch as an attachment. I'll 
start doing that as others have mentioned mangling, as well.

Attachment: feather2.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]