[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51985: lint: Adjust patch file length check.
From: |
Vagrant Cascadian |
Subject: |
bug#51985: lint: Adjust patch file length check. |
Date: |
Sat, 18 Dec 2021 00:26:50 -0800 |
On 2021-11-28, Ludovic Courtès wrote:
> Vagrant Cascadian <vagrant@debian.org> skribis:
>> On 2021-11-25, Ludovic Courtès wrote:
...
>> From c0738574a3571977855d655c157ab0ea0f9be6ef Mon Sep 17 00:00:00 2001
>> From: Vagrant Cascadian <vagrant@debian.org>
>> Date: Fri, 26 Nov 2021 12:13:45 -0800
>> Subject: [PATCH] lint: Adjust patch file length check.
>>
>> With the switch to "ustar" format in commit
>> bdf5c16ac052af2ca9d5c3acc4acbc08fd9fdbea, the maximum file length has
>> increased.
>>
>> * guix/lint.scm (check-patch-file-names): Adjust margin used to check for
>> patch file lengths. Increase allowable patch file length appropriate to new
>> tar format. Extend warning to explain that long files may break 'make
>> dist'.
>> * tests/lint.scm: Update tests accordingly.
>
> [...]
>
>> + (G_ "~a: file name is too long which may break
>> 'make dist'")
>
> I think you need a comma before “which”, but other than that LGTM! :-)
Pushed as 5f547a5c425cc99553ea713703e09a8db9f3c38b with the suggested
comma, and a brief comment explaining what the magic number "151" was
about.
That should bright all the patches into compliance with lint as far as
file length goes, and should work with the ustar format for the "make
dist" produced tarballs.
Don't get too crazy with the extra ~50 characters!
live well,
vagrant
signature.asc
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#51985: lint: Adjust patch file length check.,
Vagrant Cascadian <=