[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#52469] [PATCH] gnu: Add opustags.
From: |
Mathieu Othacehe |
Subject: |
[bug#52469] [PATCH] gnu: Add opustags. |
Date: |
Sun, 19 Dec 2021 17:09:18 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hey Leo,
> + (lambda* (#:key inputs #:allow-other-keys)
> + (let* ((perl-list-moreutils-lib
> + (string-append (assoc-ref inputs "perl-list-moreutils")
> + "/lib/perl5/site_perl/"
> + ,(package-version perl)))
> + (perl-exporter-tiny-lib
> + (string-append (assoc-ref inputs "perl-exporter-tiny")
> + "/lib/perl5/site_perl/"
> + ,(package-version perl))))
I guess you can use gexps and this-package-input to avoid relying on
input labels explicitly.
> + (inputs
> + `(("libogg" ,libogg)))
> + (native-inputs
> + `(("pkg-config" ,pkg-config)
> + ;; For the test suite
> + ("ffmpeg" ,ffmpeg)
> + ("perl-exporter-tiny" ,perl-exporter-tiny)
> + ("perl-list-moreutils" ,perl-list-moreutils)
> + ("perl-test-harness" ,perl-test-harness)))
And adapt those lists to the new style.
Otherwise looks fine,
Thanks,
Mathieu