[bug#47979] [PATCH v7 2/3] installer: Recommend 'ntp-service-type' for non-graphical systems.

[Leo Famulari]

On Mon, Dec 27, 2021 at 05:24:09PM -0500, Leo Famulari wrote:
> The system test "gui-installed-os" passes with this commit, but
> "gui-installed-desktop-os-encrypted" fails like this:
> 
> ------
> [...]
> conversation expecting pattern ((quote checkbox-list) ((quote title) "Network 
> service") ((quote text) _) ((quote items) services))
> Dec 27 23:03:44 localhost installer[194]: form #<newt-form 176e9c0> ("Network 
> service"): client 19 replied () 
> Dec 27 23:03:44 localhost installer[194]: running form #<newt-form 171ae70> 
> ("Network management") with 1 clients 
> conversation expecting pattern ((quote list-selection) ((quote title) 
> "Network management") ((quote multiple-choices?) #f) ((quote items) services))
> Dec 27 23:03:44 localhost installer[194]: form #<newt-form 171ae70> ("Network 
> management"): client 19 replied "DHCP client (dynamic IP address assignment)" 
> Dec 27 23:03:44 localhost installer[194]: running form #<newt-form 176fcb0> 
> ("Console services") with 1 clients 
> conversation expecting pattern ((quote checkbox-list) ((quote title) "Console 
> services") ((quote text) _) ((quote items) services) ((quote null?) (quote 
> desktop-environments)))
> /gnu/store/bvbv7a5nfzqwq5d7z33kqr8yzx1q5x70-shepherd-marionette.scm:1:1718: 
> ERROR:
>   1. &pattern-not-matched:
>       pattern: ((quote checkbox-list) ((quote title) "Console services") 
> ((quote text) _) ((quote items) services) ((quote null?) (quote 
> desktop-environments)))
>       sexp: (checkbox-list (title "Console services") (text "Select 
> miscellaneous services to run on your non-graphical system.") (items 
> ("Network time service (NTP), to set the clock automat)
> Backtrace:
>            2 (primitive-load "/gnu/store/ipxa2igymg4j2b84ivka5qcp5bs?")
> In ice-9/eval.scm:
>    191:35  1 (_ #f)
>     619:8  0 (_ #(#<directory (guile-user) 7ffff5fdbc80> #<variabl?>))
> 
> ice-9/eval.scm:619:8: Throw to key `marionette-eval-failure' with args 
> `((quote (choose-services installer-socket #:choose-desktop-environment? 
> (const #f) #:choose-network-service? (const #f).
> note: keeping build directory `/tmp/guix-build-installation.drv-9'
> builder for `/gnu/store/792rdywf5nzn6rs4as5v9la5sdbwqrjp-installation.drv' 
> failed with exit code 1
> build of /gnu/store/792rdywf5nzn6rs4as5v9la5sdbwqrjp-installation.drv failed
> ------
> 
> It seems that this page is being run even when a desktop is selected,
> which does not happen when using the installer directly.
> 
> Can somebody help me write the system test correctly, so that it's not
> run when a desktop is selected?

Any ideas, Mathieu?