[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#53063] [PATCH wip-harden-installer 08/14] installer: Use run-comman
From: |
Mathieu Othacehe |
Subject: |
[bug#53063] [PATCH wip-harden-installer 08/14] installer: Use run-command-in-installer in (gnu installer parted). |
Date: |
Fri, 07 Jan 2022 11:58:40 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello Josselin,
> * gnu/installer/parted.scm (remove-logical-devices,
> create-btrfs-file-system, create-ext4-file-system,
> create-fat16-file-system, create-fat32-file-system,
> create-jfs-file-system, create-ntfs-file-system,
> create-xfs-file-system, create-swap-partition, luks-format-and-open,
> luks-close): Use run-command-in-installer.
> (with-null-output-ports): Remove.
Overall the series looks really nice! This one is a bit problematic as
it breaks the installer tests because the extra "External command"
pages are not handled.
--8<---------------cut here---------------start------------->8---
Jan 7 11:44:28 localhost
conversation expecting pattern ((quote list-selection) ((quote title)
"Partitioning method") ((quote multiple-choices?) #f) ((quote items)
(not-encrypted encrypted _ ...)))
/gnu/store/6c0dnvp7a1sym52s4yrjzm3wvbsv1666-shepherd-marionette.scm:1:1718:
ERROR:
1. &pattern-not-matched:
pattern: ((quote list-selection) ((quote title) "Partitioning method")
((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...)))
sexp: (confirmation (title "External command") (text "The installer will
run the following command:\n\"dmsetup\" \"remove_all\"\n"))
Backtrace:
Jan 7 11:44:28 localhost installer[193]: running form #<newt-form 184bd30>
("External command") with 1 clients
2 (primitive-load "/gnu/store/qpsq43z9rdb7hlabzzyz6p8pzxb?")
In ice-9/eval.scm:
191:35 1 (_ #f)
619:8 0 (_ #(#<directory (guile-user) 7ffff3fd7c80> #<variabl?>))
ice-9/eval.scm:619:8: Throw to key `marionette-eval-failure' with args `((quote
(choose-partitioning installer-socket #:encrypted? #f #:passphrase
"thepassphrase" #:uefi-support? #f)))'.
note: keeping build directory `/tmp/guix-build-installation.drv-0'
builder for `/gnu/store/6xrbsa0psm30189rigjif17c6rvi8h9g-installation.drv'
failed with exit code 1
--8<---------------cut here---------------end--------------->8---
Maybe we could only display those "External command" pages when the
command fails?
Another issue is that if any partitioning command fails, the installer
keeps going. Maybe we should instead propose to abort the installation
or restart the partitioning step?
Thanks,
Mathieu
- [bug#53063] [PATCH wip-harden-installer 00/14] General improvements to the installer, Josselin Poiret, 2022/01/06
- [bug#53063] [PATCH wip-harden-installer 01/14] installer: Use define instead of let at top-level., Josselin Poiret, 2022/01/06
- [bug#53063] [PATCH wip-harden-installer 04/14] installer: Un-export syslog syntax., Josselin Poiret, 2022/01/06
- [bug#53063] [PATCH wip-harden-installer 02/14] installer: Generalize logging facility., Josselin Poiret, 2022/01/06
- [bug#53063] [PATCH wip-harden-installer 03/14] installer: Use new installer-log-line everywhere., Josselin Poiret, 2022/01/06
- [bug#53063] [PATCH wip-harden-installer 05/14] installer: Capture external commands output., Josselin Poiret, 2022/01/06
- [bug#53063] [PATCH wip-harden-installer 06/14] installer: Disable automatic finalization for child thread., Josselin Poiret, 2022/01/06
- [bug#53063] [PATCH wip-harden-installer 07/14] installer: Add installer-specific run command process., Josselin Poiret, 2022/01/06
- [bug#53063] [PATCH wip-harden-installer 08/14] installer: Use run-command-in-installer in (gnu installer parted)., Josselin Poiret, 2022/01/06
- [bug#53063] [PATCH wip-harden-installer 08/14] installer: Use run-command-in-installer in (gnu installer parted).,
Mathieu Othacehe <=
- [bug#53063] [PATCH wip-harden-installer 08/14] installer: Use run-command-in-installer in (gnu installer parted)., Josselin Poiret, 2022/01/07
- [bug#53063] [PATCH v2 wip-harden-installer 00/18] General improvements to the installer, Josselin Poiret, 2022/01/15
- [bug#53063] [PATCH v2 wip-harden-installer 04/18] installer: Un-export syslog syntax., Josselin Poiret, 2022/01/15
- [bug#53063] [PATCH v2 wip-harden-installer 03/18] installer: Use new installer-log-line everywhere., Josselin Poiret, 2022/01/15
- [bug#53063] [PATCH v2 wip-harden-installer 08/18] installer: Add installer-specific run command process., Josselin Poiret, 2022/01/15
- [bug#53063] [PATCH v2 wip-harden-installer 06/18] installer: Remove specific logging code., Josselin Poiret, 2022/01/15
- [bug#53063] [PATCH v2 wip-harden-installer 13/18] installer: Add nano to PATH., Josselin Poiret, 2022/01/15
- [bug#53063] [PATCH v2 wip-harden-installer 12/18] installer: Replace run-command by invoke in newt/page.scm., Josselin Poiret, 2022/01/15
- [bug#53063] [PATCH v2 wip-harden-installer 09/18] installer: Use run-command-in-installer in (gnu installer parted)., Josselin Poiret, 2022/01/15
- [bug#53063] [PATCH v2 wip-harden-installer 02/18] installer: Generalize logging facility., Josselin Poiret, 2022/01/15