[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#53222] [PATCH] gnu: autokey fix paths.
From: |
John Kehayias |
Subject: |
[bug#53222] [PATCH] gnu: autokey fix paths. |
Date: |
Fri, 14 Jan 2022 20:40:11 +0000 |
Hi Maxime,
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, January 13th, 2022 at 2:34 AM, Maxime Devos wrote:
>> I can submit a patch to change the wrap and inputs if that would be cleaner.
>
> * Maybe you make the GUIX_PYTHONPATH wrapping explicit (e.g. by
> removing the wrap phase, or moving the 'wrap-autokey' phase before
> the 'wrap', or letting it replace the 'wrap' phase), adding a comment
>
> ;; Use 'prefix' instead of '=' to allow the user to use additional
> ;; Python libraries from their autokey scripts.
> * or maybe don't do that, but still add a similar comment to the 'wrap'
> phase.
> * Could you make the comment next to #:tests? a bit more explicit?
>
Okay, I hope I understood correctly, attached is a patch with these updates (on
top of the already applied originally package addition).
I noticed that autokey-shell had calls to ipython3 (or python3) that should
have been substituted, so I did that with the added input for ipython3.
Added the comment about the tests and GI_TYPELIB_PATH. Note that this is there
because otherwise the gtk pieces won't run as it needs the girepository (I
think this is also the reason this is done in most cases?). I did add the
comment you suggested so it is clear this is prefix in case there are other GI
paths a user wants, and that the GUIX_PYTHONPATH wrapping is done by
python-build-system already.
Thanks again!
John
0001-gnu-autokey-Fix-paths.patch
Description: Text Data