[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#53525] [PATCH] gnu: Add emacs-puni
From: |
Niklas Eklund |
Subject: |
[bug#53525] [PATCH] gnu: Add emacs-puni |
Date: |
Tue, 25 Jan 2022 17:18:13 +0000 |
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
>
> Niklas Eklund <niklas.eklund@posteo.net> writes:
>
>> Subject: [PATCH] gnu: Add emacs-puni
>
> Thank you.
>
>> +(define-public emacs-puni
>> + ;; No tagged release upstream
>> + (let ((commit "ed4a863460329a3019c286ff382e2ddc0ffdc9d7") (revision "0"))
>
> Nitpick: could you add a newline character between (commit ...) and
> (revision ...)?
Oops, how did that end up there, of course!
>> + (home-page "https://github.com/AmaiKinono/puni")
>> + (synopsis "Parentheses Universalistic")
>
> This synopsis is not very useful. Could you expound it a bit?
Will give it a go :)
>> + (description
>> + "Structured editing (soft deletion, expression navigating &
>> manipulating) that supports many major modes out of the box.")
>
> Description are expected to consist of full sentences. I suggest:
>
> Puni is an Emacs minor mode for structured editing: soft deletion,
> expression navigating and manipulating. It supports many major modes
> out of the box.
>
> Could you send an updated patch?
>
> Regards,
> --
> Nicolas Goaziou
Absolutely, thanks for the feedback :)
Here is an updated patch.
Best regards,
Niklas
0001-gnu-Add-emacs-puni.patch
Description: emacs-puni