[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54368] [PATCH 0/4] Add Btrfs RAID10 install tests.
From: |
Maxim Cournoyer |
Subject: |
[bug#54368] [PATCH 0/4] Add Btrfs RAID10 install tests. |
Date: |
Fri, 18 Mar 2022 09:28:36 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi Mathieu,
Mathieu Othacehe <othacehe@gnu.org> writes:
> Hello Maxim,
>
> This looks great! I created a dedicated jobset here:
> https://ci.guix.gnu.org/jobset/wip-btrfs-raid-tests to check everything
> is still running fine.
>
>> +OS to install TARGET-OS. Return the VM disk images of TARGET-SIZE bytes
>> +containing the installed system. Unless providing OS, the PACKAGES will be
>> +added to the packages defined in INSTALLATION-OS (from (gnu system
>> install)).
>> +NUMBER-OF-DISKS can be used to specify a number of disks different than one,
>> +such as for RAID systems."
>
> I'm having troubles understanding the "Unless providing OS" part of the
> sentence, but that's also because this mechanism of adding packages to
> the default OS definition is tricky.
>
> Maybe we should augment the OS definition with those packages
> unconditionally in the body of the "run-install" procedure.
Yes, it's a bit weird that we accept an argument whose only purpose is
to affect the default value of another argument! I'll try implementing
your idea; I also think it's better.
Thank you!
Maxim
- [bug#54368] [PATCH 0/4] Add Btrfs RAID10 install tests., Maxim Cournoyer, 2022/03/13
- [bug#54368] [PATCH 1/4] tests: install: Adjust the timeouts on two failing tests., Maxim Cournoyer, 2022/03/13
- [bug#54368] [PATCH 2/4] tests: install: Streamline 'qemu-command/writable-image'., Maxim Cournoyer, 2022/03/13
- [bug#54368] [PATCH 4/4] tests: install: Add two new Btrfs RAID10 install test., Maxim Cournoyer, 2022/03/13
- [bug#54368] [PATCH 3/4] tests: install: Enable the use of multiple disk devices for tests., Maxim Cournoyer, 2022/03/13
- [bug#54368] [PATCH 0/4] Add Btrfs RAID10 install tests., Mathieu Othacehe, 2022/03/18
- [bug#54368] [PATCH 0/4] Add Btrfs RAID10 install tests., Maxim Cournoyer, 2022/03/18
- [bug#54368] [PATCH 0/4] Add Btrfs RAID10 install tests., Mathieu Othacehe, 2022/03/18