[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54659] [PATCH 2/2] services: Add 'log-cleanup' service to '%base-se
From: |
Ludovic Courtès |
Subject: |
[bug#54659] [PATCH 2/2] services: Add 'log-cleanup' service to '%base-services' for build logs. |
Date: |
Fri, 01 Apr 2022 17:41:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi!
Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> skribis:
>> + ;; Periodically delete build logs more than 4 months old.
>> + (service log-cleanup-service-type
>> + (log-cleanup-configuration
>> + (directory "/var/log/guix/drvs")
>> + (expiry (* 4 30 24 3600))))
>> +
> This might be very nitpicky, but I think we should leave expiry
> undefined so that the default of 6 months is applied. This way, if
> there's a future decision that all logs should probably kept e.g. for
> only 3 months, there is just one place to edit rather than two.
Yeah, dunno; I thought we’d rather be explicit, but maybe you’re right.
Ludo’.