guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#54869] [PATCH v2 1/7] gnu: fenics-dolfin: Honor #:tests? flag.


From: Maxime Devos
Subject: [bug#54869] [PATCH v2 1/7] gnu: fenics-dolfin: Honor #:tests? flag.
Date: Fri, 22 Apr 2022 19:46:52 +0200
User-agent: Evolution 3.38.3-1

Paul A. Patience schreef op vr 22-04-2022 om 11:53 [+0000]:
> -                  (invoke "ctest" "-R" "demo" "-R" "mpi")))))))
> +           (lambda* (#:key tests? #:allow-other-keys)
> +             (when tests?
> +               (and (invoke "make" "unittests")
> +                    (invoke "make" "demos")
> +                    (invoke "ctest" "-R" "unittests")
> +                    (invoke "ctest" "-R" "demo" "-R" "serial")
> +                    (invoke "ctest" "-R" "demo" "-R" "mpi"))))))))

The 'and' is pointless, it can be removed --- IIUC, 'invoke' throws
exceptions, it doesn't return #false.  Anyway, honouring #:tests? is
nice (for cross-compilation and --without-tests=...).

Greetings,
Maxime.

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]