[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54918] [WIP] make guix-service-type more extendable
From: |
Ludovic Courtès |
Subject: |
[bug#54918] [WIP] make guix-service-type more extendable |
Date: |
Sat, 30 Apr 2022 16:18:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi Justin,
Justin Veilleux <terramorpha@cock.li> skribis:
> I realize that this change isn't trivial as it breaks some people's
> os.scm and requires updating the documentation, but I think it is a
> very low hanging fruit in terms of functionality.
I think the risk of breakage is low: the previous extension mechanism
had only one use case, qemu-binfmt. That use case is now gone, so we
should be fine.
> +(define-record-type* <guix-extension>
> + guix-extension make-guix-extension
> + guix-extension?
> + (authorized-keys guix-extension-authorized-keys ;list of gexps
> + (default '()))
> + (substitute-urls guix-extension-substitute-urls ;list of strings
> + (default '()))
> + (chroot-directories guix-extension-chroot-directories ;list of
> file-like/strings
> + (default '())))
I like this approach!
Together with update documentation and a changelog, it LGTM. Could you
send an updated patch?
Thanks,
Ludo’.