[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#46182] [PATCH] lint: Add 'check-git-protocol' checker.
From: |
Maxim Cournoyer |
Subject: |
[bug#46182] [PATCH] lint: Add 'check-git-protocol' checker. |
Date: |
Sun, 22 May 2022 00:15:21 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
tags 46182 +moreinfo
thanks
Hello,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi!
>
> Leo Famulari <leo@famulari.name> skribis:
>
>> We could also make it warn about use of the HTTP protocol (as opposed to
>> HTTPS). Your thoughts?
>>
>> * guix/lint.scm (check-git-protocol): New procedure.
>> (%local-checkers): Add 'git-protocol' checker.
>> * doc/guix.texi (Invoking guix lint): Document it.
>
> Nice! I think it’s OK to use ‘eqv?’ here (‘eq?’, even).
>
> One nit: it would be nice to add a positive and a negative test in
> tests/lint.scm. You can run “make check TESTS=tests/lint.scm” then.
>
> Otherwise LGTM!
Gentle ping to Leo :-).
It looks near ready.
Thank you!
Maxim
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#46182] [PATCH] lint: Add 'check-git-protocol' checker.,
Maxim Cournoyer <=