[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#55663] [PATCH] Image API: add FAT32 support
|
From: |
Mathieu Othacehe |
|
Subject: |
[bug#55663] [PATCH] Image API: add FAT32 support |
|
Date: |
Mon, 30 May 2022 09:01:18 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hello Pavel,
> gnu/build/image.scm | 24 ++++++++++++++----------
> gnu/system/image.scm | 9 +++++++--
Please write a commit message following the guidelines available here:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html
> +(define* (make-vfat-image partition target root fs_bits)
s/fs_bits/fs-bits/
> + ((or (string=? file-system "vfat") (string=? file-system "fat16"))
> "0x0E")
This line is longer than 78 characters you can break it between the two
strings comparisons.
> + (
> + (or (string=? file-system "vfat")
Merge those two lines.
> + (string=? file-system "fat32")
> + ) "F")
Ditto.
Can you please send a v2?
Thanks for your contribution,
Mathieu