[bug#55961] [PATCH 3/9] gnu: Add node-protocol-buffers-schema.

[Marius Bakke]

Nicolas Graves via Guix-patches via <guix-patches@gnu.org> skriver:

> * gnu/packages/node-xyz.scm (node-protocol-buffers-schema): New variable.
> ---
>  gnu/packages/node-xyz.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
> index af3745f601..3f49955e29 100644
> --- a/gnu/packages/node-xyz.scm
> +++ b/gnu/packages/node-xyz.scm
> @@ -233,6 +233,36 @@ (define-public node-oop
>  while being as light-weight and simple as possible.")
>        (license license:expat))))
>  
> +(define-public node-protocol-buffers-schema
> +  (package
> +    (name "node-protocol-buffers-schema")
> +    (version "3.6.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/mafintosh/protocol-buffers-schema";)
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +          (base32
> +           "0lnckxj14jzsnfxdd5kmlwrac43c214bv8i2g5rdldymlpxzrz1v"))))
> +    (build-system node-build-system)
> +    (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (delete 'check)
> +         (replace 'configure
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (invoke (string-append (assoc-ref inputs "node") "/bin/npm")
> +                     "--offline" "--ignore-scripts" "install" "--production")
> +             #t)))))

Same comments as before regarding arguments and indentation.

> +    (home-page "https://github.com/mafintosh/protocol-buffers-schema";)
> +    (synopsis "No nonsense protocol buffers schema parser written in 
> Javascript")

Avoid marketing words such as "no-nonsense".  :-)

Otherwise LGTM.

signature.asc
Description: PGP signature