[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#56354] [PATCH] gnu: engineering: Add candle.
From: |
Artyom V. Poptsov |
Subject: |
[bug#56354] [PATCH] gnu: engineering: Add candle. |
Date: |
Sat, 09 Jul 2022 16:43:56 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hello Jean Pierre De Jesus DIAZ,
I almost overlooked your message from debbugs as it wasn't delivered to
my mailbox. Thanks for the patch review!
> Can be changed to use G-Expressions:
Done.
> >+ (add-after 'fix-sources 'fix-application-settings-path
> Doesn't depend on 'fix-sources, so it's fine to add after 'unpack.
Done.
> It may also be a good idea to set `QMAKE_CC' variable for cross-compilation,
> like:
>
> `(invoke "qmake" (string-append "QMAKE_CC=" #$(cc-for-target)))'
Done.
But I wasn't able to run cross-compilation with the command you
provided:
--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix build --keep-failed --target=aarch64-linux-gnu candle
guix build: error: gnu/packages/freedesktop.scm:1921:2:
perl-file-mimeinfo@0.29: build system `perl' does not support cross builds
--8<---------------cut here---------------end--------------->8---
It seems to me from the message that the issue is not in the candle
package itself.
> >+ (add-after 'configure 'fix-makefile
> >+ (lambda _
> >+ (substitute* "Makefile"
> >+ (("-pipe -Z7") "-pipe")
> >+ (("LFLAGS.*=.*DEBUG .*OPT:REF -Wl,-O1")
> >+ "LFLAGS = -Wl,-O1"))))
>
> Could this instead be replaced on the `candle.pro' file?
I fixed it by using the latest commit from the 'master' branch instead
of 1.2b tag.
Please find the updated patch attached.
0001-gnu-engineering-Add-candle.patch
Description: Text Data
Thanks,
- Artyom
--
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F
signature.asc
Description: PGP signature