[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#56706] [PATCH 02/17] gnu: Tryton application and framework: Update
From: |
Maxime Devos |
Subject: |
[bug#56706] [PATCH 02/17] gnu: Tryton application and framework: Update to 6.2.x. |
Date: |
Fri, 22 Jul 2022 19:25:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 |
On 22-07-2022 17:47, Hartmut Goebel wrote:
gnu/packages/tryton.scm | 708 ++++++++++++++++++++--------------------
1 file changed, 360 insertions(+), 348 deletions(-)
We usually ask patch submitters to split their patches unrelated parts
-- these updates are all related, but (guix)Submitting Patches clarifies
it as:
13. Verify that your patch contains only one set of related changes.
Bundling unrelated changes together makes reviewing harder and
slower.
Examples of unrelated changes include the _addition of several
packages_, or a package update along with fixes to that package.
(emphasis mine), I assume this also includes _updates of several packages_.
Unless they need to all be updated at the same time, it seems that this
patch should be split for the usual reasons, though I don't know how
"hard" this guideline is.
TBC, I'm mostly doing other things than reviewing at the moment (though
I don't expect any problems aside from the patch splitting conventions,
but the subject line of patch 03/17 sprang out as unexpected.
Greetings,
Maxime.
OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
- [bug#56706] [PATCH 00/17] Update Tryton to 6.2., Hartmut Goebel, 2022/07/22
- [bug#56706] [PATCH 06/17] gnu: Add trytond-account-stock-shipment-cost., Hartmut Goebel, 2022/07/22
- [bug#56706] [PATCH 14/17] gnu: Add trytond-stock-package-shipping-sendcloud., Hartmut Goebel, 2022/07/22
- [bug#56706] [PATCH 10/17] gnu: Add trytond-product-image., Hartmut Goebel, 2022/07/22
- [bug#56706] [PATCH 12/17] gnu: Add trytond-sale-point., Hartmut Goebel, 2022/07/22
- [bug#56706] [PATCH 16/17] gnu: Add python-shopifyapi., Hartmut Goebel, 2022/07/22
- [bug#56706] [PATCH 17/17] gnu: Add trytond-web-shop-shopify., Hartmut Goebel, 2022/07/22
- [bug#56706] [PATCH 01/17] gnu: Add python-pycountry@20.7.3., Hartmut Goebel, 2022/07/22
- [bug#56706] [PATCH 09/17] gnu: Add trytond-currency-rs., Hartmut Goebel, 2022/07/22