guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#58614] [PATCH 000/187] Remove unused crates


From: Efraim Flashner
Subject: [bug#58614] [PATCH 000/187] Remove unused crates
Date: Sat, 22 Oct 2022 22:35:22 +0300

On Sat, Oct 22, 2022 at 07:49:34AM +0200, Julien Lepiller wrote:
> I'm wondering why we want to do that? Are those outdated maybe? At this rate 
> we'll remove all crates :)

Would it be that bad? :)

The cargo ecosystem relies pretty heavily on semver and due to the
upgrade cycle we don't always remove old crates when nothing else
depends on them. I'd guess that some of them might be part of an
upstream-all-dependencies move (which I've done before) and most of them
are probably just outdated.

> Le 21 octobre 2022 18:21:47 GMT+02:00, Christopher Baines <mail@cbaines.net> 
> a écrit :
> >
> >Efraim Flashner <efraim@flashner.co.il> writes:
> >
> >> This is round 1 of removing unreferenced crates. All of the crates
> >> removed _should_ have no dependencies inside Guix proper. I used the
> >> command listed below and then manually searched for the lines ending
> >> with ':1' and made sure the package definition was the only reference to
> >> that package.
> >>
> >> grep define-public gnu/packages/crates-*scm | \
> >>     awk '{print $NF}' | xargs -I{} sh -c 'echo {} && git grep -c {}'
> >>
> >> I then removed all the packages and rebuilt all the modules which used
> >> the cargo-build-system somewhere inside them and rebuilt all the
> >> modules.
> >>
> >> git grep -c cargo-build-system | cut -f1 -d':' | grep \\.scm$ | \
> >>     sed -e 's/scm/go/' | xargs -n1 rm
> >>
> >> Efraim Flashner (187):
<snip>
> >>
> >>  gnu/packages/crates-graphics.scm |  187 --
> >>  gnu/packages/crates-gtk.scm      |   59 -
> >>  gnu/packages/crates-io.scm       | 4645 ------------------------------
> >>  3 files changed, 4891 deletions(-)
> >>
> >>
> >> base-commit: 3bb145b6e2a8c84e7739ead9ae76dc4d42bb9850
> >
> >This looks good to me: https://qa.guix.gnu.org/issue/58614
> >
> >Thanks,
> >
> >Chris

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]