[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#59560] [PATCH v2 2/2] gnu: emacs-lpy: Update to fa95b11.
From: |
Nicolas Goaziou |
Subject: |
[bug#59560] [PATCH v2 2/2] gnu: emacs-lpy: Update to fa95b11. |
Date: |
Sat, 26 Nov 2022 11:35:47 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello,
jgart via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-lpy): Update to fa95b11.
> [propagated-inputs]: Add missing emacs-function-args.
Thanks.
> - (let ((commit "ce78a4613458790cc785c1687af7eed8f0d8d66c")
> - (revision "5"))
> + (let ((commit "fa95b11e1023704510cc7dd2897bf8bcc3027cbb")
> + (revision "0"))
You should reset revision only when bumping base version. The fact that
commit happen to be sorted in the right order is too subtle. I vote for
(revision "6").
> (package
> (name "emacs-lpy")
> (version (git-version "0.1.0" revision commit))
> @@ -11124,10 +11124,10 @@ (define-public emacs-lpy
> (commit commit)))
> (sha256
> (base32
> - "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
> + "1j92ll2afvcp891fxra3sawxg000cs3ra01wxksiil2dg5zpzzkn"))
> (file-name (git-file-name name version))))
> (propagated-inputs
> - (list emacs-zoutline emacs-lispy))
> + (list emacs-zoutline emacs-lispy emacs-function-args))
While you're at it, could you sort inputs alphabetically, too?
Regards,
--
Nicolas Goaziou