guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#59177] [PATCH] python-protobuf: Use C++ implementation


From: Ontje.Luensdorf
Subject: [bug#59177] [PATCH] python-protobuf: Use C++ implementation
Date: Tue, 29 Nov 2022 08:23:37 +0000

Hi Ludovic,


Ludovic Courtès <ludo@gnu.org> writes:

> Impressive.  It would be nice to have that info as a comment in the code
> for future reference.

...

> Does it really need to be propagated?  Would be nice if this could be
> avoided, for instance by adding a phase that hardcodes the absolute file
> name of the protobuf shared library, if that’s the reason why it’s being
> propagated.   And if we really have to propagate it, then it’d be nice
> to clarify what.  WDYT?

you are right, it doesn't need to be propagated, the python shared
object paths look good if inputs is used instead of propagated-inputs
(thanks, good to know :)

$ ldd 
/gnu/store/r6lxp1x9lj0a4980730pyd44mcvqv8pr-python-protobuf-3.20.1/lib/python3.9/site-packages/google/protobuf/pyext/_message.cpython-39-x86_64-linux-gnu.so
 
        linux-vdso.so.1 (0x00007ffe50ba5000)
        libprotobuf.so.32 => 
/gnu/store/75d8pq1yxixr10dxfw59lv8k294nrck5-protobuf-3.21.9/lib/libprotobuf.so.32
 (0x00007ffa6b600000)
...

I've also added a comment in the updated patch below.

Thanks & best regards,
Ontje

Attachment: 0001-gnu-python-protobuf-Use-C-implementation.patch
Description: 0001-gnu-python-protobuf-Use-C-implementation.patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]